-
-
Notifications
You must be signed in to change notification settings - Fork 830
Conversation
Fixed now. |
@matrix-org/design Are the updated emojis as in the screenshots above okay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems fine. I would be a bit worried about scroll jumps, but that might be something to watch for after landing.
@rkfg apologies this slipped through the cracks in PR review. @jryans I can't seem to load the netlify deployment preview, is to review, is it possible to rebuild? |
@nadonomy The Netlify build works for me. Netlify is just slow the first time someone accesses one of the builds. |
Hi there, thanks for working on this. While I agree that some emojis are hard to recognise because the are too small, I do think in the proposed solution the emojis are a little too big. I worry that with this implementation, the emojis take up too much attention and might distract the users, along with increasing the height of each line. |
I've been using this patch since I opened this PR and I can't say the emojis are too big. They're approximately the same size as in Discord, readable and not distracting at all (their purpose is to quickly convey an emotion, if you have to spend a lot of time looking narrowly at them they fail that purpose). And as you can tell from the screenshots above, they don't increase the line height. We have huge images that take 2/3 of the screen height and they're somehow not considered distracting. I understand it's subjective but the default size is so small it's not possible to tell what emoji there is. Maybe it's easier if your font is large but it's not a solution. Almost every messenger/social media website/app I saw shows them bigger than the regular text. See Twitter for example. On GitHub they're also too small imo but still bigger than the text. |
Like I said earlier, I agree that emojis need to be bigger and currently it's hard to view them as they are. I was wondering if they could be reduced a smidge bit so it doesn't seem drastically and distractingly big. It is definitely subjective but I can user test this internally and see what different users think to get some validation. I also want to add that I am not sure if it's fair to compare images to emojis. They both have different intent and purpose. |
Yes it does. 👯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the design approval on this, sorry. It still looks good code-wise, so landing.
Thanks!
Fixes element-hq/element-web#2890
Previous attempt is outdated because emojis don't use images now and thus can't be easily styled.
The regular inline emojis are too small by default and it's hard to recognize them. The only way to make them look good is to post only emojis as a single message, then they become much bigger. This pull request makes regular emojis much more readable like in other mainstream messengers.
Before:
After:
Signed-off-by: Sergey Shpikin [email protected]
Preview: https://618158226af8110aa94c88f8--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.